This revision was automatically updated to reflect the committed changes.
Closed by commit rL353054: [clangd] Enable include insertion for static index
(authored by kadircet, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
CHANGES SINC
kadircet updated this revision to Diff 185052.
kadircet added a comment.
- Delete unnecessary include
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57508/new/
https://reviews.llvm.org/D57508
Files:
clangd/ClangdServer.cpp
clangd/ClangdUnit.cpp
kadircet marked an inline comment as done.
kadircet added a comment.
I don't think so, since the only reason this already wasn't enabled was because
there was a fixme ? Also we want people to use -background-index by default in
future so I think it should be OK
Repository:
rCTE Clang Tools E
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
lgtm.
Note that this will enable include insertions for everyone (even without index
switched on). Not sure if we should provide options.
Comment at: clangd/ClangdServer.cp
kadircet added inline comments.
Comment at: clangd/ClangdUnit.cpp:100
+ : File(File), ParsedCallback(ParsedCallback),
+IWYUHandler(collectIWYUHeaderMaps(&CanonIncludes)) {}
ioeric wrote:
> Does this have to own the `IWYUHandler`? Could we create on
kadircet updated this revision to Diff 185030.
kadircet marked 6 inline comments as done.
kadircet added a comment.
- Address comments.
- Call addSystemHeaderMappings when we are building ast without preamble.
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm
ioeric added inline comments.
Herald added a project: clang.
Comment at: clangd/ClangdUnit.cpp:100
+ : File(File), ParsedCallback(ParsedCallback),
+IWYUHandler(collectIWYUHeaderMaps(&CanonIncludes)) {}
Does this have to own the `IWYUHandler`? Could
