This revision was automatically updated to reflect the committed changes.
Closed by commit rL353030: [clang] Add getCommentHandler to PreambleCallbacks
(authored by kadircet, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
CHANGES SINC
kadircet updated this revision to Diff 184998.
kadircet marked an inline comment as done.
kadircet added a comment.
Herald added a project: clang.
- Update comment
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57507/new/
https://reviews.llvm.org/D57507
Files:
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM, just a few nits
Comment at: include/clang/Frontend/PrecompiledPreamble.h:286
virtual std::unique_ptr createPPCallbacks();
+ /// Adds the returned Comm
kadircet created this revision.
kadircet added reviewers: ilya-biryukov, ioeric.
Herald added a subscriber: cfe-commits.
Enables users to add comment handlers to preprocessor when building
preambles.
Repository:
rC Clang
https://reviews.llvm.org/D57507
Files:
include/clang/Frontend/Precomp
