[PATCH] D57325: [clangd] Collect macros in static index.

2019-01-31 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. Herald added a project: clang. So I'm not sure this is actually going to be a win. When building google's big static index, we index these symbols and then throw most of them away (a high usage threshold applies). But there's no mechanism here to do that. If we do inde

[PATCH] D57325: [clangd] Collect macros in static index.

2019-01-30 Thread Haojian Wu via Phabricator via cfe-commits
hokein marked an inline comment as done. hokein added inline comments. Comment at: unittests/clangd/BackgroundIndexTests.cpp:128 runFuzzyFind(Idx, ""), UnorderedElementsAre(Named("common"), Named("A_CC"), Named("g"), AllOf(Named("f_b"), D

[PATCH] D57325: [clangd] Collect macros in static index.

2019-01-30 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet added inline comments. Comment at: unittests/clangd/BackgroundIndexTests.cpp:128 runFuzzyFind(Idx, ""), UnorderedElementsAre(Named("common"), Named("A_CC"), Named("g"), AllOf(Named("f_b"), Declared(), Not(Defined(); -

[PATCH] D57325: [clangd] Collect macros in static index.

2019-01-28 Thread Haojian Wu via Phabricator via cfe-commits
hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ioeric, ilya-biryukov. We are missing macros in static index. symbols: before 407 K vs after 420 K dex memory usage (static index): before 299 MB vs 304 MB Reposito