This revision was automatically updated to reflect the committed changes.
Closed by commit rL352362: [clang-tidy] Add the abseil-duration-addition check
(authored by hwright, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D57185?vs=183
JonasToth accepted this revision.
JonasToth added a comment.
This revision is now accepted and ready to land.
LGTM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57185/new/
https://reviews.llvm.org/D57185
___
cfe-commits mailing list
cfe-com
hwright updated this revision to Diff 183583.
hwright marked an inline comment as done.
hwright added a comment.
Add another test
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57185/new/
https://reviews.llvm.org/D57185
Files:
clang-tidy/abseil/AbseilTidyModule.cpp
clang-tidy/abseil
JonasToth added inline comments.
Comment at: test/clang-tidy/abseil-duration-addition.cpp:84
+#undef PLUS_FIVE
+}
hwright wrote:
> JonasToth wrote:
> > a view template test-cases would be good to have.
> I'm not sure I know that terminology; do you have an exampl
hwright marked 2 inline comments as done.
hwright added inline comments.
Comment at: test/clang-tidy/abseil-duration-addition.cpp:84
+#undef PLUS_FIVE
+}
JonasToth wrote:
> a view template test-cases would be good to have.
I'm not sure I know that terminology; do
JonasToth added inline comments.
Comment at: clang-tidy/abseil/DurationAdditionCheck.cpp:22
+void DurationAdditionCheck::registerMatchers(MatchFinder *Finder) {
+ Finder->addMatcher(
+ binaryOperator(hasOperatorName("+"),
hwright wrote:
> JonasToth wrote:
>
hwright added inline comments.
Comment at: clang-tidy/abseil/DurationAdditionCheck.cpp:22
+void DurationAdditionCheck::registerMatchers(MatchFinder *Finder) {
+ Finder->addMatcher(
+ binaryOperator(hasOperatorName("+"),
JonasToth wrote:
> This whole file is
hwright updated this revision to Diff 183539.
hwright marked 11 inline comments as done.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57185/new/
https://reviews.llvm.org/D57185
Files:
clang-tidy/abseil/AbseilTidyModule.cpp
clang-tidy/abseil/CMakeLists.txt
clang-tidy/abseil/Duratio
hwright updated this revision to Diff 183531.
hwright added a comment.
Sort release notes
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57185/new/
https://reviews.llvm.org/D57185
Files:
clang-tidy/abseil/AbseilTidyModule.cpp
clang-tidy/abseil/CMakeLists.txt
clang-tidy/abseil/Dura
JonasToth added inline comments.
Comment at: clang-tidy/abseil/DurationAdditionCheck.cpp:22
+void DurationAdditionCheck::registerMatchers(MatchFinder *Finder) {
+ Finder->addMatcher(
+ binaryOperator(hasOperatorName("+"),
This whole file is structurally sim
Eugene.Zelenko added inline comments.
Comment at: docs/ReleaseNotes.rst:76
+- New :doc:`abseil-duration-addition
+ ` check.
Please use alphabetical order for new checks.
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.o
hwright created this revision.
hwright added reviewers: hokein, aaron.ballman, JonasToth.
hwright added a project: clang-tools-extra.
Herald added subscribers: cfe-commits, xazax.hun, mgorny.
This is an analog to the existing `abseil-duration-subtraction` check.
Repository:
rCTE Clang Tools Ex
12 matches
Mail list logo
