[PATCH] D57135: [ExprConstant] Unify handling of array init with lvalues.

2019-01-24 Thread Eli Friedman via Phabricator via cfe-commits
efriedma abandoned this revision. efriedma added a comment. I'm now convinced this is the wrong approach. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57135/new/ https://reviews.llvm.org/D57135 ___ cfe-commits maili

[PATCH] D57135: [ExprConstant] Unify handling of array init with lvalues.

2019-01-23 Thread Eli Friedman via Phabricator via cfe-commits
efriedma created this revision. efriedma added a reviewer: rsmith. This should have no functional effect; evaluation is still generating the same result. But the assertions and comments should make it more clear what's actually happening. Part of a fix to https://bugs.llvm.org/show_bug.cgi?id