[PATCH] D57102: [extra] unit tests enable crash-recovery cases on FreeBSD

2019-01-23 Thread David CARLIER via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rCTE352031: [extra] unit tests enable crash-recovery cases on FreeBSD (authored by devnexen, committed by ). Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57102

[PATCH] D57102: [extra] unit tests enable crash-recovery cases on FreeBSD

2019-01-23 Thread David CARLIER via Phabricator via cfe-commits
devnexen added a comment. I did filled the form already ... do not know if it needs days to take effects ... Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57102/new/ https://reviews.llvm.org/D57102 ___

[PATCH] D57102: [extra] unit tests enable crash-recovery cases on FreeBSD

2019-01-23 Thread Stephen Kelly via Phabricator via cfe-commits
steveire added a comment. You may need to accept the new license terms: http://lists.llvm.org/pipermail/llvm-dev/2019-January/129069.html Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57102/new/ https://reviews.llvm.org/D57102 __

[PATCH] D57102: [extra] unit tests enable crash-recovery cases on FreeBSD

2019-01-23 Thread David CARLIER via Phabricator via cfe-commits
devnexen added a comment. Seems I can t commit myself to the svn repo ... had moved to git ? Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57102/new/ https://reviews.llvm.org/D57102 ___ cfe-commits mail

[PATCH] D57102: [extra] unit tests enable crash-recovery cases on FreeBSD

2019-01-23 Thread David CARLIER via Phabricator via cfe-commits
devnexen added a comment. In D57102#1368373 , @steveire wrote: > The question was whether there is a build-bot for FreeBSD (if there is, then > it is covered by CI). > > Doesn't matter though. If no such bot exists, this isn't the commit to > enforce req

[PATCH] D57102: [extra] unit tests enable crash-recovery cases on FreeBSD

2019-01-23 Thread Stephen Kelly via Phabricator via cfe-commits
steveire added a comment. The question was whether there is a build-bot for FreeBSD (if there is, then it is covered by CI). Doesn't matter though. If no such bot exists, this isn't the commit to enforce requiring one! Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://

[PATCH] D57102: [extra] unit tests enable crash-recovery cases on FreeBSD

2019-01-23 Thread David CARLIER via Phabricator via cfe-commits
devnexen added a comment. In D57102#1368309 , @steveire wrote: > Is this covered by CI? The tests pass. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57102/new/ https://reviews.llvm.org/D57102 _

[PATCH] D57102: [extra] unit tests enable crash-recovery cases on FreeBSD

2019-01-23 Thread Stephen Kelly via Phabricator via cfe-commits
steveire accepted this revision. steveire added a comment. This revision is now accepted and ready to land. Is this covered by CI? Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57102/new/ https://reviews.llvm.org/D57102 __

[PATCH] D57102: [extra] unit tests enable crash-recovery cases on FreeBSD

2019-01-23 Thread David CARLIER via Phabricator via cfe-commits
devnexen created this revision. devnexen added a reviewer: steveire. devnexen created this object with visibility "All Users". Herald added a subscriber: cfe-commits. Seems the previous statement does not hold up anymore. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D57102 Fil