[PATCH] D57063: [CMake] Unify scripts for generating VCS headers

2019-02-09 Thread Michał Górny via Phabricator via cfe-commits
mgorny added a comment. Submitted a fix as D57996 . Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57063/new/ https://reviews.llvm.org/D57063 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D57063: [CMake] Unify scripts for generating VCS headers

2019-02-08 Thread Michał Górny via Phabricator via cfe-commits
mgorny added a comment. (apparently because the `CMAKE_MODULE_PATH` logic relies on going backwards to find `cmake/modules` and does not account that the modules will actually be in the same directory) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57063/new/ ht

[PATCH] D57063: [CMake] Unify scripts for generating VCS headers

2019-02-08 Thread Michał Górny via Phabricator via cfe-commits
mgorny added a comment. @phosek, I'm sorry to say but this is apparently breaking stand-alone clang builds: FAILED: lib/Basic/VCSVersion.inc cd /var/tmp/portage/sys-devel/clang-/work/x/y/clang--abi_x86_64.amd64/lib/Basic && /usr/bin/cmake -DNAMES="LLVM;CLANG" -DLLVM_SOURCE_DIR= -D

[PATCH] D57063: [CMake] Unify scripts for generating VCS headers

2019-02-05 Thread Petr Hosek via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC353268: [CMake] Unify scripts for generating VCS headers (authored by phosek, committed by ). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit: https://revi