[PATCH] D57012: Merge similar target diagnostics for interrupt attribute into one. NFC

aaron.ballman closed this revision. aaron.ballman added a comment. I've commit in r351969, thank you for the patch! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57012/new/ https://reviews.llvm.org/D57012 ___ cfe-com

[PATCH] D57012: Merge similar target diagnostics for interrupt attribute into one. NFC

krisb added a comment. @aaron.ballman yes and yes. Thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57012/new/ https://reviews.llvm.org/D57012 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists

[PATCH] D57012: Merge similar target diagnostics for interrupt attribute into one. NFC

aaron.ballman added a comment. In D57012#1365939 , @krisb wrote: > @aaron.ballman Thanks! Could I ask you to commit the patch? I don't have > commit access yet. Happy to do so -- just to double-check: are you aware of the recent relicensing of the proj

[PATCH] D57012: Merge similar target diagnostics for interrupt attribute into one. NFC

krisb added a comment. @aaron.ballman Thanks! Could I ask you to commit the patch? I don't have commit access yet. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57012/new/ https://reviews.llvm.org/D57012 ___ cfe-com

[PATCH] D57012: Merge similar target diagnostics for interrupt attribute into one. NFC

krisb updated this revision to Diff 182852. krisb added a comment. Applied the comment. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57012/new/ https://reviews.llvm.org/D57012 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaDeclAttr.cpp Ind

[PATCH] D57012: Merge similar target diagnostics for interrupt attribute into one. NFC

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a commenting nit, thank you for the cleanup! Comment at: lib/Sema/SemaDeclAttr.cpp:5620 +S.Diag(D->getLocation(), diag::warn_interrupt_attri

[PATCH] D57012: Merge similar target diagnostics for interrupt attribute into one. NFC

krisb created this revision. krisb added reviewers: asl, aaron.ballman. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D57012 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaDeclAttr.cpp Index: lib/Sema/SemaDeclAttr.cpp ==