[PATCH] D56935: [NewPM] Add support for new-PM plugins to clang

melver added a comment. In D56935#1382156 , @philip.pfaffe wrote: > Landed it for you in r352972. Thanks! Great, thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56935/new/ https://reviews.llvm.org/D56935 _

[PATCH] D56935: [NewPM] Add support for new-PM plugins to clang

philip.pfaffe added a comment. Landed it for you in r352972. Thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56935/new/ https://reviews.llvm.org/D56935 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D56935: [NewPM] Add support for new-PM plugins to clang

This revision was automatically updated to reflect the committed changes. Closed by commit rC352972: [NewPM] Add support for new-PM plugins to clang (authored by pfaffe, committed by ). Changed prior to commit: https://reviews.llvm.org/D56935?vs=183715&id=184922#toc Repository: rC Clang CHA

[PATCH] D56935: [NewPM] Add support for new-PM plugins to clang

melver added a comment. Gentle ping. Need someone to land this on my behalf, as I do not have commit access. Many thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56935/new/ https://reviews.llvm.org/D56935 ___ cfe-commits mailing list

[PATCH] D56935: [NewPM] Add support for new-PM plugins to clang

melver added a comment. In D56935#1370861 , @philip.pfaffe wrote: > It would be good to check, since the bots won't! Otherwise this looks good. Thanks! I attempted to test on Windows, but noticed that for a shared library CMake already reports "Loadab

[PATCH] D56935: [NewPM] Add support for new-PM plugins to clang

melver updated this revision to Diff 183715. melver added a comment. - Improve error reporting. While testing on Windows, noticed that Clang wants the error to be checked otherwise crashed quite verbosely. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56935/new/ https://reviews.llvm.or

[PATCH] D56935: [NewPM] Add support for new-PM plugins to clang

philip.pfaffe accepted this revision. philip.pfaffe added a comment. This revision is now accepted and ready to land. It would be good to check, since the bots won't! Otherwise this looks good. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56935/new/ https://reviews.llvm.org/D56935 _

[PATCH] D56935: [NewPM] Add support for new-PM plugins to clang

melver added a comment. Thanks! In D56935#1367545 , @philip.pfaffe wrote: > I'm not sure what the current state of plugins on windows is. They were > broken and disabled last time I worked on this, but that might've changed in > the meantime! Worth che

[PATCH] D56935: [NewPM] Add support for new-PM plugins to clang

melver updated this revision to Diff 183140. melver added a comment. - Revert use of SmallVector CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56935/new/ https://reviews.llvm.org/D56935 Files: clang/include/clang/Basic/CodeGenOptions.h clang/include/clang/Driver/Options.td clang/

[PATCH] D56935: [NewPM] Add support for new-PM plugins to clang

philip.pfaffe added a comment. I'm not sure what the current state of plugins on windows is. They were broken and disabled last time I worked on this, but that might've changed in the meantime! Worth checking. Comment at: clang/include/clang/Basic/CodeGenOptions.h:292 + ///

[PATCH] D56935: [NewPM] Add support for new-PM plugins to clang

melver added a comment. >> This generally looks sane. What will happen on windows though? Will it >> silently fa > > AFAIK PassPlugin::Load uses sys::DynamicLibrary::getPermanentLibrary, which > uses DynamicLibrary::HandleSet::AddLibrary which works for Windows as well. > (The story is similar

[PATCH] D56935: [NewPM] Add support for new-PM plugins to clang

melver added a comment. Thanks! In D56935#1366756 , @philip.pfaffe wrote: > This generally looks sane. What will happen on windows though? Will it > silently fail? AFAIK PassPlugin::Load uses sys::DynamicLibrary::getPermanentLibrary, which uses Dynam

[PATCH] D56935: [NewPM] Add support for new-PM plugins to clang

melver updated this revision to Diff 182974. melver marked 2 inline comments as done. melver added a comment. - Use SmallVector in CodeGenOptions.h CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56935/new/ https://reviews.llvm.org/D56935 Files: clang/include/clang/Basic/CodeGenOptions

[PATCH] D56935: [NewPM] Add support for new-PM plugins to clang

philip.pfaffe added a comment. This generally looks sane. What will happen on windows though? Will it silently fail? Comment at: clang/include/clang/Basic/CodeGenOptions.h:292 + /// List of dynamic shared object files to be loaded as pass plugins. + std::vector PassPlugins;