[PATCH] D56927: Disable PIC/PIE for MSP430 target

This revision was automatically updated to reflect the committed changes. Closed by commit rL353877: Disable PIC/PIE for MSP430 target (authored by asl, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION https:

[PATCH] D56927: Disable PIC/PIE for MSP430 target

grimar added a comment. Ok, please ignore my comments above. I applied the patch and found it creates the test in `llvm\tools\clang\test\CodeGen` and not in `llvm\test\CodeGen`. Was confused by phab, sorry for the noise. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D56927: Disable PIC/PIE for MSP430 target

grimar added a comment. Oh sorry, I looked in the wrong folder, my previous comment was not correct. So, this patch adds a test to `test\CodeGen` when we have `test\CodeGen\MSP430` folder. And `test\CodeGen` does not have any tests now at all. So I **guess** the correct way would probably be: 1

[PATCH] D56927: Disable PIC/PIE for MSP430 target

grimar added a comment. What I noticed, this seems to introduce the first test case in `test\CodeGen\MSP430` folder which uses `clang`. All the others use `llc`. Is it OK? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56927/new/ https://reviews.llvm.org/D56927

[PATCH] D56927: Disable PIC/PIE for MSP430 target

dmikushin updated this revision to Diff 184118. dmikushin added a comment. Unbreaking patch by providing an appropriate toolchain requirement Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56927/new/ https://reviews.llvm.org/D56927 Files: lib/Driver/ToolChains/

[PATCH] D56927: Disable PIC/PIE for MSP430 target

asl requested changes to this revision. asl added a comment. This revision now requires changes to proceed. Please make sure the test passes. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56927/new/ https://reviews.llvm.org/D56927 _

[PATCH] D56927: Disable PIC/PIE for MSP430 target

asl reopened this revision. asl added a comment. This revision is now accepted and ready to land. The patch was reverted – the test requires fully configured msp430 configuration and therefore was breaking the bots. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D5

[PATCH] D56927: Disable PIC/PIE for MSP430 target

This revision was automatically updated to reflect the committed changes. Closed by commit rC352181: Disable PIC/PIE for MSP430 target by default. (authored by asl, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56927/new/ https://reviews.llvm.org/D

[PATCH] D56927: Disable PIC/PIE for MSP430 target

dmikushin updated this revision to Diff 183214. dmikushin added a comment. Adding test case Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56927/new/ https://reviews.llvm.org/D56927 Files: lib/Driver/ToolChains/MSP430.h test/CodeGen/msp430-reloc.c Index: te

[PATCH] D56927: Disable PIC/PIE for MSP430 target

grimar added a comment. Can it be tested with a test case? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56927/new/ https://reviews.llvm.org/D56927 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists

[PATCH] D56927: Disable PIC/PIE for MSP430 target

dmikushin created this revision. dmikushin added a reviewer: asl. Herald added a subscriber: cfe-commits. Relocatable code generation is meaningless on MSP430, as the platform is too small to use shared libraries. Repository: rC Clang https://reviews.llvm.org/D56927 Files: lib/Driver/Tool