steveire marked an inline comment as done.
steveire added inline comments.
Comment at: lib/AST/TextNodeDumper.cpp:276-280
+ if (!C) {
+ColorScope Color(OS, ShowColors, NullColor);
+OS << "<<>> OMPClause";
+return;
+ }
aaron.ballman wrote:
> This pat
This revision was automatically updated to reflect the committed changes.
Closed by commit rL351236: NFC: Implement OMPClause dump in terms of visitors
(authored by steveire, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D56708?vs=181
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM aside from a nit.
Comment at: lib/AST/ASTDumper.cpp:1462
const OMPExecutableDirective *Node) {
- for (auto *C : Node->clauses()) {
-dumpChild([=]
steveire updated this revision to Diff 181749.
steveire added a comment.
Update
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56708/new/
https://reviews.llvm.org/D56708
Files:
include/clang/AST/TextNodeDumper.h
lib/AST/ASTDumper.cpp
lib/AST/TextNodeDumper.
steveire created this revision.
steveire added a reviewer: aaron.ballman.
Herald added a subscriber: cfe-commits.
Repository:
rC Clang
https://reviews.llvm.org/D56708
Files:
include/clang/AST/TextNodeDumper.h
lib/AST/ASTDumper.cpp
lib/AST/TextNodeDumper.cpp
Index: lib/AST/TextNodeDumpe
