This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE351170: [clangd] Fix updated file detection logic in
indexing (authored by kadircet, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D56592?vs=181735&id=181736#toc
Repository:
rCT
kadircet updated this revision to Diff 181735.
kadircet marked 6 inline comments as done.
kadircet added a comment.
- Address comments
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56592/new/
https://reviews.llvm.org/D56592
Files:
clangd/index/Ba
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM after the NITs are fixed. Unless there are other significant changes
planned that I need to look at.
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https
ilya-biryukov added a comment.
This looks neat, thanks for the change!
Just a few NITs from my side
Comment at: clangd/index/Background.cpp:264
+/// Given index results from a TU, only update symbols coming from files with
+/// different digests than \p DigestsSnapshot. Also st
kadircet updated this revision to Diff 181545.
kadircet added a comment.
- Update comments
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56592/new/
https://reviews.llvm.org/D56592
Files:
clangd/index/Background.cpp
clangd/index/Background.h
u
kadircet updated this revision to Diff 181544.
kadircet added a comment.
- Change FileFilter and update logic to do not care about if there are any
symbols coming from a file.
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56592/new/
https://reviews
kadircet added inline comments.
Comment at: clangd/index/Background.cpp:309
for (const auto &I : *Index.Sources) {
+// We already have the map from uris to absolutepaths in the cache,
+// therefore traverse Index.Sources rather than Files to get rid of
absolute
--
