[PATCH] D56523: Improve a -Wunguarded-availability note

This revision was automatically updated to reflect the committed changes. Closed by commit rC351108: Improve a -Wunguarded-availability note (authored by epilk, committed by ). Changed prior to commit: https://reviews.llvm.org/D56523?vs=181130&id=181616#toc Repository: rC Clang CHANGES SINC

[PATCH] D56523: Improve a -Wunguarded-availability note

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56523/new/ https://reviews.llvm.org/D56523 ___ cfe-commits mailing list cfe-commi

[PATCH] D56523: Improve a -Wunguarded-availability note

erik.pilkington added inline comments. Comment at: clang/test/Sema/availability-guard-format.mm:6 @interface foo -- (void) method_bar __attribute__((availability(macosx, introduced = 10_12))); // expected-note {{'method_bar' has been explicitly marked partial here}} +- (void) m

[PATCH] D56523: Improve a -Wunguarded-availability note

erik.pilkington updated this revision to Diff 181130. erik.pilkington marked an inline comment as done. erik.pilkington added a comment. Fix some triples in the tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56523/new/ https://reviews.llvm.org/D56523 Files: clang/include/clang/

[PATCH] D56523: Improve a -Wunguarded-availability note

dexonsmith added inline comments. Comment at: clang/test/Sema/availability-guard-format.mm:6 @interface foo -- (void) method_bar __attribute__((availability(macosx, introduced = 10_12))); // expected-note {{'method_bar' has been explicitly marked partial here}} +- (void) method

[PATCH] D56523: Improve a -Wunguarded-availability note

erik.pilkington marked an inline comment as done. erik.pilkington added inline comments. Comment at: clang/test/Sema/availability-guard-format.mm:6 @interface foo -- (void) method_bar __attribute__((availability(macosx, introduced = 10_12))); // expected-note {{'method_bar' has

[PATCH] D56523: Improve a -Wunguarded-availability note

jkorous added a reviewer: jkorous. jkorous added a comment. Hi Erik, this looks neat! Comment at: clang/test/Sema/availability-guard-format.mm:6 @interface foo -- (void) method_bar __attribute__((availability(macosx, introduced = 10_12))); // expected-note {{'method_bar' has

[PATCH] D56523: Improve a -Wunguarded-availability note

erik.pilkington created this revision. erik.pilkington added a reviewer: arphaman. Herald added subscribers: dexonsmith, jkorous. Mention the deployment target, and don't say "partial" which doesn't really mean anything to users. rdar://problem/33601513 Repository: rC Clang https://reviews.