[PATCH] D56504: [WebAssembly] Add unimplemented-simd128 feature, gate builtins

2019-01-10 Thread Thomas Lively via Phabricator via cfe-commits
tlively closed this revision. tlively added a comment. Closed by commit rC350909 . Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56504/new/ https://reviews.llvm.org/D56504 ___ cfe-c

[PATCH] D56504: [WebAssembly] Add unimplemented-simd128 feature, gate builtins

2019-01-10 Thread Thomas Lively via Phabricator via cfe-commits
tlively added inline comments. Comment at: include/clang/Basic/BuiltinsWebAssembly.def:53 // Saturating fp-to-int conversions -BUILTIN(__builtin_wasm_trunc_saturate_s_i32_f32, "if", "nc") -BUILTIN(__builtin_wasm_trunc_saturate_u_i32_f32, "if", "nc") -BUILTIN(__builtin_wasm_trunc

[PATCH] D56504: [WebAssembly] Add unimplemented-simd128 feature, gate builtins

2019-01-10 Thread Thomas Lively via Phabricator via cfe-commits
tlively updated this revision to Diff 181171. tlively marked an inline comment as done. tlively added a comment. - Change names again to reflect latest committed LLVM change Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56504/new/ https://reviews.llvm.org/D56504

[PATCH] D56504: [WebAssembly] Add unimplemented-simd128 feature, gate builtins

2019-01-09 Thread Thomas Lively via Phabricator via cfe-commits
tlively updated this revision to Diff 180984. tlively added a comment. - Match the new naming scheme from rL350791 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56504/new/ https://reviews.llvm.org/D56504 Files: include/clang

[PATCH] D56504: [WebAssembly] Add unimplemented-simd128 feature, gate builtins

2019-01-09 Thread Heejin Ahn via Phabricator via cfe-commits
aheejin added inline comments. Comment at: include/clang/Basic/BuiltinsWebAssembly.def:53 // Saturating fp-to-int conversions -BUILTIN(__builtin_wasm_trunc_saturate_s_i32_f32, "if", "nc") -BUILTIN(__builtin_wasm_trunc_saturate_u_i32_f32, "if", "nc") -BUILTIN(__builtin_wasm_trunc

[PATCH] D56504: [WebAssembly] Add unimplemented-simd128 feature, gate builtins

2019-01-09 Thread Thomas Lively via Phabricator via cfe-commits
tlively updated this revision to Diff 180921. tlively added a comment. - Decouple sign-ext from simd128 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56504/new/ https://reviews.llvm.org/D56504 Files: include/clang/Basic/BuiltinsWebAssembly.def include/clang/

[PATCH] D56504: [WebAssembly] Add unimplemented-simd128 feature, gate builtins

2019-01-09 Thread Thomas Lively via Phabricator via cfe-commits
tlively created this revision. tlively added reviewers: aheejin, dschuff. Herald added subscribers: cfe-commits, kristina, sunfish, jgravelle-google, sbc100. Depends on D56501 . Also adds a macro define __wasm_unimplemented_simd128__ for feature detection of unimp