[PATCH] D56438: [Modules] Allow modulemap path change for implicitly built modules

2019-01-08 Thread Yuka Takahashi via Phabricator via cfe-commits
yamaguchi added a comment. We have both explicitly and implicitly prebuilt modules, but this patch only relates to implicit ones. I agree that our usecase is a bit unique where we're installing and distributing implicitly built pcm, but I also imagine there might be a usecase where you built im

[PATCH] D56438: [Modules] Allow modulemap path change for implicitly built modules

2019-01-08 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added a comment. No doubt @rsmith will have a more nuanced/accurate opinion on this than I do, but I would've thought the point of implicit modules is that they don't get moved around & it sounds like that's what this patch is suggesting/supporting, but maybe I haven't understood it fu

[PATCH] D56438: [Modules] Allow modulemap path change for implicitly built modules

2019-01-08 Thread Yuka Takahashi via Phabricator via cfe-commits
yamaguchi created this revision. yamaguchi added reviewers: rsmith, dblaikie. Previous code was comparing the location of "modulemap which is currently loaded and gives a definition of current module" and "the location of the modulemap where the current implicit module was built". This check was