[PATCH] D56430: Incorrect implicit data-sharing for nested tasks

This revision was automatically updated to reflect the committed changes. Closed by commit rL350734: Incorrect implicit data-sharing for nested tasks (authored by ABataev, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D56430?vs=180844

[PATCH] D56430: Incorrect implicit data-sharing for nested tasks

ABataev added a comment. In D56430#1351212 , @smateo wrote: > I don't have commit access yet. Would you mind to commit it for me? Thanks!, > > Sergi Sure, no problems. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56430/

[PATCH] D56430: Incorrect implicit data-sharing for nested tasks

smateo added a comment. I don't have commit access yet. Would you mind to commit it for me? Thanks!, Sergi Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56430/new/ https://reviews.llvm.org/D56430 ___ cfe-commits mai

[PATCH] D56430: Incorrect implicit data-sharing for nested tasks

ABataev added a comment. Will you commit this patch? Or I should do it? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56430/new/ https://reviews.llvm.org/D56430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D56430: Incorrect implicit data-sharing for nested tasks

smateo updated this revision to Diff 180844. smateo added a comment. Done! Thanks, Sergi Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56430/new/ https://reviews.llvm.org/D56430 Files: lib/Sema/SemaOpenMP.cpp test/OpenMP/task_messages.cpp Index: test/OpenM

[PATCH] D56430: Incorrect implicit data-sharing for nested tasks

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. In D56430#1350706 , @smateo wrote: > Renaming the `isParallelRegion` function to `isImplicitTaskingRegion`. > > Shall we rename the `isParallelOrTaskR

[PATCH] D56430: Incorrect implicit data-sharing for nested tasks

smateo updated this revision to Diff 180792. smateo added a comment. Renaming the `isParallelRegion` function to `isImplicitTaskingRegion`. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56430/new/ https://reviews.llvm.org/D56430 Files: lib/Sema/SemaOpenMP.cpp

[PATCH] D56430: Incorrect implicit data-sharing for nested tasks

ABataev added inline comments. Comment at: lib/Sema/SemaOpenMP.cpp:680 + +bool isParallelRegion(OpenMPDirectiveKind DKind) { + return isOpenMPParallelDirective(DKind) || isOpenMPTeamsDirective(DKind); Better to rename it to `isImplicitTaskingRegion` Repository

[PATCH] D56430: Incorrect implicit data-sharing for nested tasks

smateo updated this revision to Diff 180631. smateo added a comment. Adding more context Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56430/new/ https://reviews.llvm.org/D56430 Files: lib/Sema/SemaOpenMP.cpp test/OpenMP/task_messages.cpp Index: test/OpenM

[PATCH] D56430: Incorrect implicit data-sharing for nested tasks

smateo created this revision. smateo added a reviewer: ABataev. smateo added a project: OpenMP. Herald added a subscriber: cfe-commits. There is a minor issue in how the implicit data-sharings for nested tasks are computed. For the following example: int x; #pragma omp task shared(x) #pra