[PATCH] D56407: Implement the TreeStructure interface through the TextNodeDumper

2019-01-08 Thread Stephen Kelly via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC350665: Implement the TreeStructure interface through the TextNodeDumper (authored by steveire, committed by ). Changed prior to commit: https://reviews.llvm.org/D56407?vs=180552&id=180742#toc Reposito

[PATCH] D56407: Implement the TreeStructure interface through the TextNodeDumper

2019-01-08 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added a comment. In D56407#1349672 , @aaron.ballman wrote: > I think this is a good approach to solving the problem, so let's go this > route. Yeah, I agree here. This ends up being a really clean solution. Repository: rC Clang CHANGES

[PATCH] D56407: Implement the TreeStructure interface through the TextNodeDumper

2019-01-08 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. I think this is a good approach to solving the problem, so let's go this route. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56407/new/ https://

[PATCH] D56407: Implement the TreeStructure interface through the TextNodeDumper

2019-01-07 Thread Stephen Kelly via Phabricator via cfe-commits
steveire created this revision. steveire added reviewers: aaron.ballman, erichkeane. Herald added a subscriber: cfe-commits. This way, when the generic ASTTraverser is extracted from ASTDumper, there can't be any problem related to ordering of class members, a concern that was raised in https://re