[PATCH] D56273: Validate -add-plugin arguments.

This revision was automatically updated to reflect the committed changes. Closed by commit rC350340: Validate -add-plugin arguments. (authored by nico, committed by ). Changed prior to commit: https://reviews.llvm.org/D56273?vs=180085&id=180099#toc Repository: rC Clang CHANGES SINCE LAST AC

[PATCH] D56273: Validate -add-plugin arguments.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56273/new/ https://reviews.llvm.org/D56273 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D56273: Validate -add-plugin arguments.

thakis marked an inline comment as done. thakis added inline comments. Comment at: clang/test/Frontend/plugin-unknown.c:3 +// RUN: not %clang_cc1 -add-plugin asdf %s 2>&1 | FileCheck --check-prefix=ADD %s +// REQUIRES: plugins + Probably doesn't even require plu

[PATCH] D56273: Validate -add-plugin arguments.

thakis updated this revision to Diff 180085. thakis added a comment. remove require CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56273/new/ https://reviews.llvm.org/D56273 Files: clang/lib/Frontend/CompilerInvocation.cpp clang/test/Frontend/plugin-unknown.c Index: clang/test/Fro

[PATCH] D56273: Validate -add-plugin arguments.

thakis updated this revision to Diff 180084. thakis added a comment. forgot to add test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56273/new/ https://reviews.llvm.org/D56273 Files: clang/lib/Frontend/CompilerInvocation.cpp clang/test/Frontend/plugin-unknown.c Index: clang/test

[PATCH] D56273: Validate -add-plugin arguments.

thakis created this revision. thakis added a reviewer: rnk. -plugin already prints an error if the name of an unknown plugin is passed. -add-plugin used to silently ignore that, now it errors too. https://reviews.llvm.org/D56273 Files: clang/lib/Frontend/CompilerInvocation.cpp Index: clang