modocache added a comment.
Thank you for the review!
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56271/new/
https://reviews.llvm.org/D56271
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.o
This revision was automatically updated to reflect the committed changes.
Closed by commit rL350501: [SemaCXX] Fix ICE for unexpanded parameter pack
(authored by modocache, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
Looks good, thank you!
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56271/new/
https://reviews.llvm.org/D56271
modocache created this revision.
modocache added a reviewer: rsmith.
The documentation for RecursiveASTVisitor::TraverseDecl states that the
Decl being traversed may be null. In fact, this is the case when a
CXXCatchStmt with no exception decl is traversed. Because the visitor
for diagnosing unexp