[PATCH] D56198: [Basic] Extend DiagnosticEngine to store and format Qualifiers

2019-01-04 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC350386: [Basic] Extend DiagnosticEngine to store and format Qualifiers. (authored by stulova, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56198/new/ http

[PATCH] D56198: [Basic] Extend DiagnosticEngine to store and format Qualifiers

2019-01-02 Thread John McCall via Phabricator via cfe-commits
rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks, LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56198/new/ https://reviews.llvm.org/D56198 ___ cfe-commits mailing list

[PATCH] D56198: [Basic] Extend DiagnosticEngine to store and format Qualifiers

2019-01-02 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia updated this revision to Diff 179887. Anastasia added a comment. Addressed review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56198/new/ https://reviews.llvm.org/D56198 Files: include/clang/AST/Type.h include/clang/Basic/Diagnostic.h include/clang/Basic/Diag

[PATCH] D56198: [Basic] Extend DiagnosticEngine to store and format Qualifiers

2019-01-02 Thread John McCall via Phabricator via cfe-commits
rjmccall added inline comments. Comment at: include/clang/AST/Type.h:6705 +/// Insertion operator for diagnostics. This allows sending Qualifiers' into a +/// diagnostic with <<. +inline const DiagnosticBuilder &operator<<(const DiagnosticBuilder &DB, Unpaired ap

[PATCH] D56198: [Basic] Extend DiagnosticEngine to store and format Qualifiers

2019-01-02 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia created this revision. Anastasia added a reviewer: rjmccall. This is a follow up patch from the following review comment: https://reviews.llvm.org/D55850?id=178767#inline-495051 https://reviews.llvm.org/D56198 Files: include/clang/AST/Type.h include/clang/Basic/Diagnostic.h inc