[PATCH] D55933: [Sema] Do not print default template parameters.

Quuxplusone added inline comments. Comment at: lib/AST/TypePrinter.cpp:179 +// `X` gets canonicalized to `X`. We disable +// canonicalization so that `printTag()`` can see the template parameters as +// written. courbet wrote: > Quuxplusone wrote: >

[PATCH] D55933: [Sema] Do not print default template parameters.

courbet added inline comments. Comment at: lib/AST/TypePrinter.cpp:179 +// `X` gets canonicalized to `X`. We disable +// canonicalization so that `printTag()`` can see the template parameters as +// written. Quuxplusone wrote: > Nit: there's an extra

[PATCH] D55933: [Sema] Do not print default template parameters.

courbet updated this revision to Diff 180220. courbet marked 2 inline comments as done. courbet added a comment. Handle {L,R}Value references. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55933/new/ https://reviews.llvm.org/D55933 Files: include/clang/AST/Nes

[PATCH] D55933: [Sema] Do not print default template parameters.

Quuxplusone added inline comments. Comment at: lib/AST/TypePrinter.cpp:179 +// `X` gets canonicalized to `X`. We disable +// canonicalization so that `printTag()`` can see the template parameters as +// written. Nit: there's an extra ` on this line.

[PATCH] D55933: [Sema] Do not print default template parameters.

courbet added inline comments. Comment at: test/SemaCXX/static-assert-cxx17.cpp:109 +template +void foo7() { + static_assert(X()); Quuxplusone wrote: > courbet wrote: > > Quuxplusone wrote: > > > None of these new test cases actually involve the default templat

[PATCH] D55933: [Sema] Do not print default template parameters.

courbet updated this revision to Diff 180035. courbet marked 2 inline comments as done. courbet added a comment. Add more tests as suggested in the comments. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55933/new/ https://reviews.llvm.org/D55933 Files: includ

[PATCH] D55933: [Sema] Do not print default template parameters.

Quuxplusone added inline comments. Comment at: test/SemaCXX/static-assert-cxx17.cpp:109 +template +void foo7() { + static_assert(X()); courbet wrote: > Quuxplusone wrote: > > None of these new test cases actually involve the default template argument. > > > >

[PATCH] D55933: [Sema] Do not print default template parameters.

courbet marked 6 inline comments as done. courbet added inline comments. Comment at: lib/AST/TypePrinter.cpp:173 + // information about whether default template parameters were actually + // written. + switch (QT.getTypePtr()->getTypeClass()) { Quuxplusone wro

[PATCH] D55933: [Sema] Do not print default template parameters.

Quuxplusone added inline comments. Comment at: lib/AST/TypePrinter.cpp:173 + // information about whether default template parameters were actually + // written. + switch (QT.getTypePtr()->getTypeClass()) { FWIW, I don't understand this comment's terminology.

[PATCH] D55933: [Sema] Do not print default template parameters.

courbet created this revision. courbet added reviewers: aaron.ballman, Quuxplusone. As a followup to D55270 . Repository: rC Clang https://reviews.llvm.org/D55933 Files: include/clang/AST/NestedNameSpecifier.h lib/AST/NestedNameSpecifier.cpp lib/AST/Typ