This revision was automatically updated to reflect the committed changes.
Closed by commit rL350068: Ignore ConstantExpr in IgnoreParens (authored by
rnk, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D55853?vs=178960&id=179515#toc
R
rnk marked 4 inline comments as done.
rnk added inline comments.
Comment at: clang/lib/AST/Expr.cpp:2550
}
+if (ConstantExpr *CE = dyn_cast(E)) {
+ E = CE->getSubExpr();
rsmith wrote:
> Does this pass the tests if you use `FullExpr` here instead? I
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM with `s/ConstantExpr/FullExpr/`.
Comment at: clang/lib/AST/Expr.cpp:2550
}
+if (ConstantExpr *CE = dyn_cast(E)) {
+ E = CE->getSubExpr();
rnk added a comment.
Want to stamp this? It's 4pm on the Friday before Christmas, what could go
wrong? :)
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55853/new/
https://reviews.llvm.org/D55853
___
cfe-commits mailing list
cfe-commits@lis
