This revision was automatically updated to reflect the committed changes.
Closed by commit rL349618: [clangd] Unify path canonicalizations in the
codebase (authored by kadircet, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://rev
kadircet updated this revision to Diff 178856.
kadircet marked 3 inline comments as done.
kadircet added a comment.
- Address comments
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55818/new/
https://reviews.llvm.org/D55818
Files:
clangd/SourceCo
ilya-biryukov accepted this revision.
ilya-biryukov added inline comments.
This revision is now accepted and ready to land.
Comment at: clangd/SourceCode.cpp:203
+FilePath)) {
+ elog("Could not turn relative path to absolute: {0}: {1}", FilePath,
+
kadircet updated this revision to Diff 178685.
kadircet marked 2 inline comments as done.
kadircet added a comment.
- Address comments
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55818/new/
https://reviews.llvm.org/D55818
Files:
clangd/SourceCo
kadircet marked 7 inline comments as done.
kadircet added inline comments.
Comment at: clangd/SourceCode.h:91
+/// possible.
+llvm::Expected getCanonicalPath(const FileEntry *F,
+ const SourceManager &SourceMgr);
ilya-b
ilya-biryukov added a comment.
The change mostly, the only important comment from me is about `toURI`. I
believe it would actually have an observable effect in the real world and I'm
not sure things won't break after it.
Could we avoid changing it and focus only on tweaking the "canonical" path
kadircet created this revision.
kadircet added a reviewer: ilya-biryukov.
Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ioeric.
There were a few different places where we canonicalized paths, each
one had its own flavor. This patch tries to unify them all under one place.
Re
