This revision was automatically updated to reflect the committed changes.
Closed by commit rL348794: Change InitListExpr dump to label and pointer
(authored by steveire, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D55495?vs=177426&i
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM aside from a small nit.
Comment at: lib/AST/ASTDumper.cpp:1956-1959
+ OS << " array_filler";
+ NodeDumper.dumpPointer(Filler);
+
dumpStmt(
steveire added a comment.
My real preference is just to remove the `array filler` child node entirely and
not add a pointer here. However, I'm just looking for something that has a
chance of passing review.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55495/new
steveire created this revision.
steveire added a reviewer: aaron.ballman.
Herald added a subscriber: cfe-commits.
Don't add a child just for the label.
Repository:
rC Clang
https://reviews.llvm.org/D55495
Files:
lib/AST/ASTDumper.cpp
test/AST/ast-dump-stmt.cpp
Index: test/AST/ast-dump-
