[PATCH] D55349: Convert some ObjC alloc msgSends to runtime calls

pete added a comment. In D55349#1323926 , @rjmccall wrote: > LGTM. Thanks for the review! Landed in r348687. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55349/new/ https://reviews.llvm.org/D55349 _

[PATCH] D55349: Convert some ObjC alloc msgSends to runtime calls

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55349/new/ https://reviews.llvm.org/D55349 ___ cfe-commits mailing list cfe-comm

[PATCH] D55349: Convert some ObjC alloc msgSends to runtime calls

pete updated this revision to Diff 177308. pete marked an inline comment as done. pete added a comment. Added test for integer argument and updated code to only accept pointer types to allocWithZone. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55349/new/ https://reviews.llvm.org/D553

[PATCH] D55349: Convert some ObjC alloc msgSends to runtime calls

rjmccall added inline comments. Comment at: lib/CodeGen/CGObjC.cpp:385 +// prefix are identified as OMF_alloc but we only want to call the +// runtime for this version. +if (Sel.isUnarySelector() && Sel.getNameForSlot(0) == "alloc") Actual

[PATCH] D55349: Convert some ObjC alloc msgSends to runtime calls

pete marked 5 inline comments as done. pete added inline comments. Comment at: include/clang/Basic/ObjCRuntime.h:200 +case WatchOS: + return true; + rjmccall wrote: > Did we really add this so long ago? Wow. Yeah! I was thinking that too! CHANGES SIN

[PATCH] D55349: Convert some ObjC alloc msgSends to runtime calls

pete updated this revision to Diff 177246. pete added a comment. Thanks for the review. Have fixed the comments as suggested. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55349/new/ https://reviews.llvm.org/D55349 Files: include/clang/Basic/ObjCRuntime.h include/clang/Driver/Opti

[PATCH] D55349: Convert some ObjC alloc msgSends to runtime calls

rjmccall added inline comments. Comment at: include/clang/Basic/ObjCRuntime.h:189 + /// When this method returns true, Clang will turn non-super message sends of + /// certain selectors into calls to the correspond entrypoint: + /// alloc => objc_alloc "corr

[PATCH] D55349: Convert some ObjC alloc msgSends to runtime calls

pete created this revision. pete added reviewers: ahatanak, rjmccall, erik.pilkington. Herald added a subscriber: cfe-commits. It is faster to directly call the ObjC runtime for methods such as alloc/allocWithZone instead of sending a message to those functions. This patch adds support for conve