[PATCH] D55337: NFC: Move dumpDeclRef to NodeDumper

2019-01-08 Thread Stephen Kelly via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC350677: [ASTDump] NFC: Move dumpDeclRef to NodeDumper (authored by steveire, committed by ). Changed prior to commit: https://reviews.llvm.org/D55337?vs=177670&id=180752#toc Repository: rC Clang CHA

[PATCH] D55337: NFC: Move dumpDeclRef to NodeDumper

2019-01-08 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Once D56407 lands, the rebased changes here LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55337/new/ http

[PATCH] D55337: NFC: Move dumpDeclRef to NodeDumper

2019-01-08 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: include/clang/AST/TextNodeDumper.h:28 const comments::FullComment *> { + TextTreeStructure &TreeStructure; raw_ostream &OS; steveire wrote: > steveire wrote: > > stev

[PATCH] D55337: NFC: Move dumpDeclRef to NodeDumper

2019-01-07 Thread Stephen Kelly via Phabricator via cfe-commits
steveire marked an inline comment as done. steveire added inline comments. Comment at: include/clang/AST/TextNodeDumper.h:28 const comments::FullComment *> { + TextTreeStructure &TreeStructure; raw_ostream &OS; stev

[PATCH] D55337: NFC: Move dumpDeclRef to NodeDumper

2019-01-05 Thread Stephen Kelly via Phabricator via cfe-commits
steveire marked an inline comment as done. steveire added inline comments. Comment at: include/clang/AST/TextNodeDumper.h:28 const comments::FullComment *> { + TextTreeStructure &TreeStructure; raw_ostream &OS; stev

[PATCH] D55337: NFC: Move dumpDeclRef to NodeDumper

2019-01-05 Thread Stephen Kelly via Phabricator via cfe-commits
steveire marked an inline comment as done. steveire added inline comments. Comment at: include/clang/AST/TextNodeDumper.h:28 const comments::FullComment *> { + TextTreeStructure &TreeStructure; raw_ostream &OS; aaro

[PATCH] D55337: NFC: Move dumpDeclRef to NodeDumper

2019-01-04 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: include/clang/AST/TextNodeDumper.h:28 const comments::FullComment *> { + TextTreeStructure &TreeStructure; raw_ostream &OS; steveire wrote: > aaron.ballman wrote: > >

[PATCH] D55337: NFC: Move dumpDeclRef to NodeDumper

2018-12-11 Thread Stephen Kelly via Phabricator via cfe-commits
steveire updated this revision to Diff 177670. steveire added a comment. Rebase Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55337/new/ https://reviews.llvm.org/D55337 Files: include/clang/AST/TextNodeDumper.h lib/AST/ASTDumper.cpp lib/AST/TextNodeDumper.

[PATCH] D55337: NFC: Move dumpDeclRef to NodeDumper

2018-12-06 Thread Stephen Kelly via Phabricator via cfe-commits
steveire marked an inline comment as done. steveire added inline comments. Comment at: include/clang/AST/TextNodeDumper.h:28 const comments::FullComment *> { + TextTreeStructure &TreeStructure; raw_ostream &OS; aaro

[PATCH] D55337: NFC: Move dumpDeclRef to NodeDumper

2018-12-06 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: include/clang/AST/TextNodeDumper.h:28 const comments::FullComment *> { + TextTreeStructure &TreeStructure; raw_ostream &OS; This makes me a bit wary because you creat

[PATCH] D55337: NFC: Move dumpDeclRef to NodeDumper

2018-12-05 Thread Stephen Kelly via Phabricator via cfe-commits
steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D55337 Files: include/clang/AST/TextNodeDumper.h lib/AST/ASTDumper.cpp lib/AST/TextNodeDumper.cpp Index: lib/AST/TextNodeDumper