[PATCH] D55331: [CodeComplete] Fix assertion failure

2018-12-07 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL348590: [CodeComplete] Fix assertion failure (authored by ibiryukov, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D55331?vs=176836&id=177187

[PATCH] D55331: [CodeComplete] Fix assertion failure

2018-12-06 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55331/new/ https://reviews.llvm.org/D55331 ___ cfe-commit

[PATCH] D55331: [CodeComplete] Fix assertion failure

2018-12-05 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov created this revision. ilya-biryukov added a reviewer: kadircet. ...that fires when running completion inside an argument of UnresolvedMemberExpr (see the added test). The assertion that fires is from Sema::TryObjectArgumentInitialization: assert(FromClassification.isLValue());