[PATCH] D55269: [CUDA] Fix nvidia-cuda-toolkit detection on Ubuntu

2019-03-14 Thread Joel E. Denny via Phabricator via cfe-commits
jdenny added a comment. Herald added a project: LLVM. In D55269#1320382 , @tra wrote: > In D55269#1320207 , @Hahnfeld wrote: > > > In D55269#1319109 , @jdenny wrote: > > > >

[PATCH] D55269: [CUDA] Fix nvidia-cuda-toolkit detection on Ubuntu

2018-12-06 Thread Joel E. Denny via Phabricator via cfe-commits
jdenny added a comment. In D55269#1320382 , @tra wrote: > >> Let's start with fixing OpenMP's cmake files. Once it no longer insists on > >> specifying --cuda-path=/usr, and isUbuntu is in place, what is the > >> remaining failure that you see? > > > >

[PATCH] D55269: [CUDA] Fix nvidia-cuda-toolkit detection on Ubuntu

2018-12-06 Thread Joel E. Denny via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL348504: [CUDA] Fix nvidia-cuda-toolkit detection on Ubuntu (authored by jdenny, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D55269?vs=17691

[PATCH] D55269: [CUDA] Fix nvidia-cuda-toolkit detection on Ubuntu

2018-12-06 Thread Artem Belevich via Phabricator via cfe-commits
tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55269/new/ https://reviews.llvm.org/D55269 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D55269: [CUDA] Fix nvidia-cuda-toolkit detection on Ubuntu

2018-12-05 Thread Joel E. Denny via Phabricator via cfe-commits
jdenny updated this revision to Diff 176916. jdenny retitled this revision from "[CUDA][OpenMP] Fix nvidia-cuda-toolkit detection on Debian/Ubuntu" to "[CUDA] Fix nvidia-cuda-toolkit detection on Ubuntu". jdenny edited the summary of this revision. jdenny added a comment. Apply reviewer suggesti