[PATCH] D55190: Move dump of individual comment nodes to NodeDumper

2018-12-09 Thread Stephen Kelly via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL348719: NFC: Move dump of individual comment nodes to NodeDumper (authored by steveire, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D55190?

[PATCH] D55190: Move dump of individual comment nodes to NodeDumper

2018-12-06 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55190/new/ https://reviews.llvm.org/D55190 ___

[PATCH] D55190: Move dump of individual comment nodes to NodeDumper

2018-12-03 Thread Stephen Kelly via Phabricator via cfe-commits
steveire updated this revision to Diff 176481. steveire added a comment. Move to implementation Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55190/new/ https://reviews.llvm.org/D55190 Files: include/clang/AST/TextNodeDumper.h lib/AST/ASTDumper.cpp lib/AST

[PATCH] D55190: Move dump of individual comment nodes to NodeDumper

2018-12-03 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. Looks reasonable, but similar to D55189 , can more of the implementation be pushed into a .cpp file rather than left in a header? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55190/new/ https://re

[PATCH] D55190: Move dump of individual comment nodes to NodeDumper

2018-12-03 Thread Stephen Kelly via Phabricator via cfe-commits
steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D55190 Files: include/clang/AST/ASTTextNodeDumper.h lib/AST/ASTDumper.cpp Index: lib/AST/ASTDumper.cpp ==