[PATCH] D55189: Extract TextNodeDumper class

This revision was automatically updated to reflect the committed changes. Closed by commit rC348412: NFC: Extract TextNodeDumper class (authored by steveire, committed by ). Changed prior to commit: https://reviews.llvm.org/D55189?vs=176478&id=176872#toc Repository: rC Clang CHANGES SINCE L

[PATCH] D55189: Extract TextNodeDumper class

steveire marked an inline comment as done. steveire added inline comments. Comment at: lib/AST/ASTDumper.cpp:90 // Utilities -void dumpPointer(const void *Ptr); -void dumpSourceRange(SourceRange R); -void dumpLocation(SourceLocation Loc); -void dumpBareType(Q

[PATCH] D55189: Extract TextNodeDumper class

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: lib/AST/ASTDumper.cpp:90 // Utilities -void dumpPointer(const void *Ptr); -void dumpSourceRange(SourceRange R); -void dumpLoc

[PATCH] D55189: Extract TextNodeDumper class

steveire updated this revision to Diff 176478. steveire added a comment. Herald added a subscriber: mgorny. Move implementation to cpp file Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55189/new/ https://reviews.llvm.org/D55189 Files: include/clang/AST/TextNo

[PATCH] D55189: Extract TextNodeDumper class

aaron.ballman added a comment. Basically looking good, modulo namespace questions from D55188 and a few other organizational questions. Comment at: include/clang/AST/ASTTextNodeDumper.h:1 +//===--- ASTTextNodeDumper.h - Printing of AST nodes

[PATCH] D55189: Extract TextNodeDumper class

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a subscriber: cfe-commits. Start by moving some utilities to it. It will eventually house dumping of individual nodes (after indentation etc has already been accounted for). Repository: rC Clang https://rev