This revision was automatically updated to reflect the committed changes.
Closed by commit rL348135: [CodeComplete] Cleanup access checking in code
completion (authored by ibiryukov, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https:
ilya-biryukov added inline comments.
Comment at: lib/Parse/ParseExprCXX.cpp:248
// seen a leading '::' or part of a nested-name-specifier.
+ ParsedType ObjectTypeForCompletion = ObjectType;
ObjectType = nullptr;
kadircet wrote:
> What about fir
ilya-biryukov updated this revision to Diff 176327.
ilya-biryukov marked 2 inline comments as done.
ilya-biryukov added a comment.
- Do not introduce a new local var, reuse existing
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55124/new/
https://reviews.llvm.org
kadircet accepted this revision.
kadircet added inline comments.
This revision is now accepted and ready to land.
Comment at: lib/Parse/ParseExprCXX.cpp:248
// seen a leading '::' or part of a nested-name-specifier.
+ ParsedType ObjectTypeForCompletion = ObjectType;
ilya-biryukov updated this revision to Diff 176153.
ilya-biryukov added a comment.
- Fix a comment
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55124/new/
https://reviews.llvm.org/D55124
Files:
include/clang/Sema/Sema.h
lib/Parse/ParseExprCXX.cpp
lib/Sema
ilya-biryukov updated this revision to Diff 176150.
ilya-biryukov added a comment.
- Add missed field init
- Also fix access checks for member access with qualifiers
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55124/new/
https://reviews.llvm.org/D55124
Files:
ilya-biryukov created this revision.
ilya-biryukov added a reviewer: ioeric.
Also fixes a crash (see the added 'accessibility-crash.cpp' test).
Repository:
rC Clang
https://reviews.llvm.org/D55124
Files:
include/clang/Sema/Sema.h
lib/Sema/CodeCompleteConsumer.cpp
lib/Sema/SemaAccess.cp
