[PATCH] D55062: [clangd] Partition include graph on auto-index.

This revision was automatically updated to reflect the committed changes. Closed by commit rL348252: [clangd] Partition include graph on auto-index. (authored by kadircet, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D55062: [clangd] Partition include graph on auto-index.

kadircet updated this revision to Diff 176594. kadircet marked 2 inline comments as done. kadircet added a comment. - Address comments Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55062/new/ https://reviews.llvm.org/D55062 Files: clangd/Headers.

[PATCH] D55062: [clangd] Partition include graph on auto-index.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Comment at: unittests/clangd/BackgroundIndexTests.cpp:204 + EXPECT_EQ(ShardSource->Sources->size(), 2U); // A.cc, A.h + EXPECT_THAT( + ShardSource->

[PATCH] D55062: [clangd] Partition include graph on auto-index.

kadircet updated this revision to Diff 176415. kadircet marked 3 inline comments as done. kadircet added a comment. - Addresss comments - Make sure there are no uninitialized values in IncludeGraphNode. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D5

[PATCH] D55062: [clangd] Partition include graph on auto-index.

ilya-biryukov added a comment. Everything looks good, just a single important request about testing the included files do not have any edges in the resulting graph Comment at: clangd/index/Background.cpp:79 + + // Since the strings in direct includes are references to the key

[PATCH] D55062: [clangd] Partition include graph on auto-index.

kadircet updated this revision to Diff 176356. kadircet added a comment. - Rebase Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55062/new/ https://reviews.llvm.org/D55062 Files: clangd/index/Background.cpp unittests/clangd/BackgroundIndexTests.

[PATCH] D55062: [clangd] Partition include graph on auto-index.

kadircet updated this revision to Diff 176323. kadircet marked 5 inline comments as done. kadircet added a comment. - Address comments Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55062/new/ https://reviews.llvm.org/D55062 Files: clangd/index/Ba

[PATCH] D55062: [clangd] Partition include graph on auto-index.

kadircet added inline comments. Comment at: clangd/index/Background.cpp:260 +std::unique_ptr IG = +Index.Sources ? llvm::make_unique(getSubGraph( +URI::create(Path), Index.Sources.getValue())) ilya-biryukov wrote: > What ar

[PATCH] D55062: [clangd] Partition include graph on auto-index.

ilya-biryukov added inline comments. Comment at: clangd/index/Background.cpp:70 +// We keep only the node "Path" and its edges. +IncludeGraph getSubGraph(const URI &Uri, const IncludeGraph &FullGraph) { + IncludeGraph IG; Naming: technically the variable name sh

[PATCH] D55062: [clangd] Partition include graph on auto-index.

kadircet added inline comments. Comment at: unittests/clangd/BackgroundIndexTests.cpp:192 +[&](llvm::StringRef) { return &MSS; }); +CDB.setCompileCommand(testPath("root"), Cmd); +ASSERT_TRUE(Idx.blockUntilIdleForTest()); ilya-biryu

[PATCH] D55062: [clangd] Partition include graph on auto-index.

kadircet updated this revision to Diff 176090. kadircet marked 7 inline comments as done. kadircet added a comment. - Address comments Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55062/new/ https://reviews.llvm.org/D55062 Files: clangd/index/Ba

[PATCH] D55062: [clangd] Partition include graph on auto-index.

ilya-biryukov added inline comments. Comment at: clangd/index/Background.cpp:184 +// We keep only the node "Path" and its edges. +IncludeGraph getSubGraph(llvm::StringRef Path, const IncludeGraph &FullGraph) { + IncludeGraph IG; We should make the function stati

[PATCH] D55062: [clangd] Partition include graph on auto-index.

kadircet created this revision. kadircet added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ioeric. Partitions include graphs in auto-index so that each shards contains only part of the include graph related to itself. Repository: rCTE Clang Too