[PATCH] D54918: [analyzer] Apply clang-format to GenericTaintChecker.cpp

2018-12-19 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC349698: [analyzer] GenericTaint: Fix formatting to prepare for incoming improvements. (authored by dergachev, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D54918: [analyzer] Apply clang-format to GenericTaintChecker.cpp

2018-12-17 Thread Borsik Gábor via Phabricator via cfe-commits
boga95 added a comment. I don't have commit access. Can you please do it on my behalf? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54918/new/ https://reviews.llvm.org/D54918 ___ cfe-commits mailing list cfe-commits

[PATCH] D54918: [analyzer] Apply clang-format to GenericTaintChecker.cpp

2018-12-17 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus added a comment. @boga95 Do you have commit access, or need this to be commited on your behalf? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54918/new/ https://reviews.llvm.org/D54918 ___ cfe-commits maili

[PATCH] D54918: [analyzer] Apply clang-format to GenericTaintChecker.cpp

2018-12-16 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ accepted this revision. NoQ added a comment. I appreciate the cleanup in general and any work on taint analysis in particular, thanks! In D54918#1332089 , @Szelethus wrote: > I vaguely remember @george.karpenkov having many great points against it --

[PATCH] D54918: [analyzer] Apply clang-format to GenericTaintChecker.cpp

2018-12-15 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus accepted this revision. Szelethus added a comment. Hmm, actually, if you're doing changes all over the file in the followup patches, it shouldn't matter much. Let's just wait a couple days for ppl to object, now that they are subscribed. Repository: rC Clang CHANGES SINCE LAST ACT

[PATCH] D54918: [analyzer] Apply clang-format to GenericTaintChecker.cpp

2018-12-15 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus added a comment. Please don't mind me intruding. If you create a patch for the Clang Static Analyzer, please add "[analyzer]" in the revision title, because many of us are automatically subscribed to those patches. Also, upload patches with full context. https://llvm.org/docs/Phabricat