This revision was automatically updated to reflect the committed changes.
Closed by commit rL347538: [clangd] Auto-index watches global CDB for changes.
(authored by sammccall, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://revi
sammccall updated this revision to Diff 175208.
sammccall marked an inline comment as done.
sammccall added a comment.
If the CDB dir is unknown, don't try to write shards to disk.
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D54865/new/
https://rev
sammccall marked 3 inline comments as done.
sammccall added inline comments.
Comment at: clangd/index/Background.cpp:130
+ if (auto Cmd = CDB.getCompileCommand(File, &Project)) {
+auto *Storage = IndexStorageFactory(Project.SourceRoot);
+enqueueTask(Bind(
---
kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
LGTM, seems to share a lot of context with what I am preparing for loading
shards.
Interfaces looks compatible with what I had before, only difference is it was
more `tooling::CompileComma
sammccall created this revision.
sammccall added reviewers: ioeric, kadircet.
Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay.
Instead of receiving compilation commands, auto-index is triggered by just
filenames to reindex, and gets commands from the global comp DB internally.
Th
