phosek added a comment.
I have already reverted the change as r347430 after seeing the failure on
sanitizer bots.
Repository:
rC Clang
https://reviews.llvm.org/D54805
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/
MaskRay added a comment.
In https://reviews.llvm.org/D54805#1305749, @pcc wrote:
> Unfortunately it looks like the Android NDK uses some ancient version of gold
> that doesn't support `--push-state`, so we probably can't rely on being able
> to use it.
>
> http://lab.llvm.org:8011/builders/sa
pcc added a comment.
Unfortunately it looks like the Android NDK uses some ancient version of gold
that doesn't support `--push-state`, so we probably can't rely on being able to
use it.
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-android/builds/17287/steps/run%20lit%20tests%20%5Bi6
This revision was automatically updated to reflect the committed changes.
Closed by commit rC347413: [Driver] Use --push/pop-state with Sanitizer link
deps (authored by phosek, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D54805?vs=174952&id=174966#toc
Repository:
rC Cla
morehouse accepted this revision.
morehouse added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rC Clang
https://reviews.llvm.org/D54805
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/
phosek created this revision.
phosek added reviewers: vitalybuka, morehouse.
Herald added subscribers: cfe-commits, jfb.
Sanitizer runtime link deps handling passes --no-as-needed because of
PR15823, but it never undoes it and this flag may affect other libraries
that come later on the link line.
