jkorous updated this revision to Diff 175475.
jkorous added a comment.
Finished tests and fixed operator<<(SymbolDetails) for containerNames that
aren't part of fully qualified name.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D54799/new/
https://reviews.llvm.org/D54799
Files:
clan
sammccall accepted this revision.
sammccall marked an inline comment as done.
sammccall added a comment.
Tests look great, thanks!
Comment at: clangd/ClangdServer.cpp:529
+
+ WorkScheduler.runWithAST("CursorInfo", File, Bind(Action, std::move(CB)));
+}
jkorous
arphaman added a comment.
LGTM, we can optimize later. It looks like you also moved `SymbolID` to a new
file, this should be an NFC precommit.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D54799/new/
https://reviews.llvm.org/D54799
___
cfe
jkorous updated this revision to Diff 175314.
jkorous marked an inline comment as done.
jkorous added a comment.
Adressed last comments + initial unit tests.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D54799/new/
https://reviews.llvm.org/D54799
Files:
CMakeLists.txt
ClangdLSPServ
jkorous marked 5 inline comments as done.
jkorous added inline comments.
Comment at: clangd/ClangdServer.cpp:529
+
+ WorkScheduler.runWithAST("CursorInfo", File, Bind(Action, std::move(CB)));
+}
sammccall wrote:
> sammccall wrote:
> > nit: SymbolInfo
> (This sti
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
LG from my side.
If you have unit tests in the next couple of days, happy to take a look,
otherwise go ahead once Alex/Ben are happy.
(I'm at work today/tomorrow and then I'm going to be
