[PATCH] D54764: [OpenMP] Update CHECK-DAG usage in for_codegen.cpp

2018-11-20 Thread Joel E. Denny via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC347350: [OpenMP] Update CHECK-DAG usage in for_codegen.cpp (authored by jdenny, committed by ). Changed prior to commit: https://reviews.llvm.org/D54764?vs=174816&id=174836#toc Repository: rC Clang

[PATCH] D54764: [OpenMP] Update CHECK-DAG usage in for_codegen.cpp

2018-11-20 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added a comment. In https://reviews.llvm.org/D54764#1304606, @jdenny wrote: > In https://reviews.llvm.org/D54764#1304573, @ABataev wrote: > > > I'm fine with the patch, > > > Thanks for the quick reviews. I'll push soon. > > > the original intention was to handle a possible situation whe

[PATCH] D54764: [OpenMP] Update CHECK-DAG usage in for_codegen.cpp

2018-11-20 Thread Joel E. Denny via Phabricator via cfe-commits
jdenny added a comment. In https://reviews.llvm.org/D54764#1304573, @ABataev wrote: > I'm fine with the patch, Thanks for the quick reviews. I'll push soon. > the original intention was to handle a possible situation where we may have > several debug locations with the same line numbers. We

[PATCH] D54764: [OpenMP] Update CHECK-DAG usage in for_codegen.cpp

2018-11-20 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. I'm fine with the patch, the original intention was to handle a possible situation where we may have several debug locations with the same line numbers. Repository: rC Clang https://revi

[PATCH] D54764: [OpenMP] Update CHECK-DAG usage in for_codegen.cpp

2018-11-20 Thread Joel E. Denny via Phabricator via cfe-commits
jdenny created this revision. jdenny added a reviewer: ABataev. Herald added a subscriber: guansong. This patch adjusts a test not to depend on deprecated FileCheck behavior that permits overlapping matches within a block of CHECK-DAG directives. Thus, this patch also removes uses of FileCheck's