sthibaul updated this revision to Diff 173604.
sthibaul added a comment.
Herald added a subscriber: srhines.
This includes version finding the gcc Hurd triplet (i[3456]-gnu) in the Gcc
detector.
Repository:
rC Clang
https://reviews.llvm.org/D54379
Files:
lib/Basic/Targets.cpp
lib/Basic/
sthibaul updated this revision to Diff 173601.
Repository:
rC Clang
https://reviews.llvm.org/D54379
Files:
lib/Basic/Targets.cpp
lib/Basic/Targets/OSTargets.h
lib/Driver/CMakeLists.txt
lib/Driver/Driver.cpp
lib/Driver/ToolChains/Clang.cpp
lib/Driver/ToolChains/Gnu.cpp
lib/Driver/
sthibaul updated this revision to Diff 173599.
sthibaul added a comment.
In this version, the Driver introduces the "-hurd-" part
Repository:
rC Clang
https://reviews.llvm.org/D54379
Files:
lib/Basic/Targets.cpp
lib/Basic/Targets/OSTargets.h
lib/Driver/CMakeLists.txt
lib/Driver/Drive
sthibaul added inline comments.
Comment at: lib/Driver/ToolChains/Hurd.cpp:136
+
+ // Add an include of '/include' directly. This isn't provided by default by
+ // system GCCs, but is often used with cross-compiling GCCs, and harmless to
krytarowski wrote:
> Is
krytarowski added inline comments.
Comment at: lib/Driver/ToolChains/Hurd.cpp:136
+
+ // Add an include of '/include' directly. This isn't provided by default by
+ // system GCCs, but is often used with cross-compiling GCCs, and harmless to
Is this some hurd st
sthibaul updated this revision to Diff 173515.
https://reviews.llvm.org/D54379
Files:
lib/Basic/Targets.cpp
lib/Basic/Targets/OSTargets.h
lib/Driver/CMakeLists.txt
lib/Driver/Driver.cpp
lib/Driver/ToolChains/Clang.cpp
lib/Driver/ToolChains/Gnu.cpp
lib/Driver/ToolChains/Hurd.cpp
li
sthibaul marked 3 inline comments as done.
sthibaul added a comment.
I commented one of them, and will fix the rest.
Comment at: lib/Driver/ToolChains/Hurd.cpp:36
+ // clever.
+ switch (TargetTriple.getArch()) {
+ default:
kristina wrote:
> Does this need a
kristina added reviewers: kristina, clang.
kristina added a comment.
A few style naming/comments.
Comment at: lib/Driver/ToolChains/Hurd.cpp:36
+ // clever.
+ switch (TargetTriple.getArch()) {
+ default:
Does this need a switch? Wouldn't an `if` be sufficien
kristina added inline comments.
Comment at: lib/Driver/ToolChains/Clang.cpp:533
- if (Triple.isOSLinux() || Triple.getOS() == llvm::Triple::CloudABI) {
+ if (Triple.isOSLinux() || Triple.getOS() == llvm::Triple::CloudABI ||
Triple.isOSHurd()) {
switch (Triple.getArch())
sthibaul added a comment.
The Hurd::Hurd constructor would actually need to do the same gcc inclusion
path detection as on Linux, but let's leave this aside for now, this commit is
enough for a build without libc++.
Repository:
rC Clang
https://reviews.llvm.org/D54379
___
sthibaul created this revision.
sthibaul added a reviewer: rengolin.
Herald added subscribers: cfe-commits, fedor.sergeev, krytarowski, mgorny.
Repository:
rC Clang
https://reviews.llvm.org/D54379
Files:
lib/Basic/Targets.cpp
lib/Basic/Targets/OSTargets.h
lib/Driver/CMakeLists.txt
lib/
11 matches
Mail list logo