[PATCH] D53925: [modules] Defer emission of inline key functions.

v.g.vassilev abandoned this revision. v.g.vassilev added a comment. Landed as D54986 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53925/new/ https://reviews.llvm.org/D53925 ___ cfe-co

[PATCH] D53925: [modules] Defer emission of inline key functions.

rsmith added a comment. If CodeGen is able to emit inline key functions when the vtable is needed anyway, can we instead change `DeclMustBeEmitted` to not treat inline key functions specially? There is no reason we need to emit any symbols for: struct A { virtual void f(); }; inline void A:

[PATCH] D53925: [modules] Defer emission of inline key functions.

rjmccall added a comment. Seems reasonable to me. Repository: rC Clang https://reviews.llvm.org/D53925 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D53925: [modules] Defer emission of inline key functions.

v.g.vassilev created this revision. v.g.vassilev added reviewers: rsmith, bruno. Herald added a subscriber: cfe-commits. If the ABI supports inline key functions we must emit them eagerly. The generic reason is that CodeGen might assume they are emitted and generate a reference to the vtable. In

[PATCH] D53925: [modules] Defer emission of inline key functions.

v.g.vassilev added a comment. @rsmith, @bruno could you verify this patch on your codebases? Repository: rC Clang https://reviews.llvm.org/D53925 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listin