[PATCH] D53808: [clangd] Don't collect refs from non-canonical headers.

2018-10-30 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. It's not obvious whether/why this is the right thing to do. One set of reasoning that occurs to me: - headers without guards produce code in some context-sensitive way, they only exist in the context of their including file - for the symbols they produce, we have ways

[PATCH] D53808: [clangd] Don't collect refs from non-canonical headers.

2018-10-29 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri added a comment. Please add a test with `#pragma once`, which should still be counted as a header guard. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D53808 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http:/

[PATCH] D53808: [clangd] Don't collect refs from non-canonical headers.

2018-10-29 Thread Haojian Wu via Phabricator via cfe-commits
hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ioeric, ilya-biryukov. With this patch, we only collect refs for canonical headers (headers with header guards). As non-canonical headers are usually generated, and no