aaron.ballman closed this revision.
aaron.ballman added a comment.
Thanks for the reviews -- I've commit in r346521.
https://reviews.llvm.org/D53700
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
rsmith accepted this revision.
rsmith added a comment.
Let's do it. The diagnostic and fix-it is awesome ;)
https://reviews.llvm.org/D53700
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.
I'm fine with `_Clang` or anything else too. Thanks for doing this!
Comment at: lib/Basic/Attributes.cpp:18
if (ScopeName == "__gnu__")
-ScopeName = ScopeName.slice(
aaron.ballman added reviewers: mclow.lists, EricWF, ldionne.
aaron.ballman added a comment.
Another option that @rsmith and I discussed today is perhaps using `__clang` or
`clang__` as the identifier, but perhaps this will cause more confusion about
where to put underscores than `_Clang` would.
aaron.ballman added a comment.
Ping
https://reviews.llvm.org/D53700
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman created this revision.
aaron.ballman added reviewers: rsmith, echristo, dblaikie.
Herald added a subscriber: krytarowski.
Currently, we only accept `clang` as the scoped attribute identifier for double
square bracket attributes provided by Clang, but this has the potential to
confl
