[PATCH] D53605: [AST] Pack PredefinedExpr

2018-10-24 Thread John McCall via Phabricator via cfe-commits
rjmccall added inline comments. Comment at: include/clang/AST/Expr.h:1687 + // "Stmt *" for the predefined identifier. It is present if and only if + // hasFunctionName() is true and is in fact a "StringLiteral *". + "always" would be clearer than "in fact".

[PATCH] D53605: [AST] Pack PredefinedExpr

2018-10-23 Thread Bruno Ricci via Phabricator via cfe-commits
riccibruno created this revision. riccibruno added a reviewer: rjmccall. riccibruno added a project: clang. Herald added a subscriber: cfe-commits. riccibruno added a dependency: D53604: [AST] Widen the bit-fields of Stmt to 8 bytes. This patch does 3 things: 1. Move PredefinedExpr below StringL