This revision was automatically updated to reflect the committed changes.
Closed by commit rL345128: [clangd] Simplify auto hover (authored by ibiryukov,
committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D53347?vs=170273&id=170835#toc
Re
ilya-biryukov added a comment.
In https://reviews.llvm.org/D53347#1267216, @kadircet wrote:
> LGTM, it bugs me that some part in the documentation says it doesn't go
> through decltype(`This looks through declarators like pointer types, but not
> through decltype or typedefs`) but since tests c
ilya-biryukov updated this revision to Diff 170273.
ilya-biryukov marked 2 inline comments as done.
ilya-biryukov added a comment.
- Addressed review comments
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53347
Files:
clangd/XRefs.cpp
unittests/clangd/XRefsTests.cpp
Inde
hokein accepted this revision.
hokein added a comment.
looks good! didn't know this API before.
Comment at: clangd/XRefs.cpp:592
-auto DeclT = UnwrapReferenceOrPointer(D->getType());
-const AutoType *AT = dyn_cast(DeclT.getTypePtr());
-if (AT && !AT->getDeducedTyp
kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
LGTM, it bugs me that some part in the documentation says it doesn't go through
decltype(`This looks through declarators like pointer types, but not through
decltype or typedefs`) but sinc
ilya-biryukov created this revision.
ilya-biryukov added reviewers: kadircet, hokein.
Herald added subscribers: arphaman, jkorous, MaskRay, ioeric.
Use helper from clang. Also fixes some weird corner cases, e.g.
auto (*foo)() = bar;
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.o
