This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE344678: [clangd] Collect refs from headers. (authored by
hokein, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D53322?vs=169967&id=169968#toc
Repository:
rCTE Clang Tools Extra
hokein updated this revision to Diff 169967.
hokein added a comment.
minor cleanup.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53322
Files:
clangd/index/IndexAction.cpp
clangd/index/IndexAction.h
clangd/index/SymbolCollector.cpp
clangd/index/SymbolCollector.h
unit
hokein added a comment.
In https://reviews.llvm.org/D53322#1266536, @sammccall wrote:
> (please do check there are no duplicates in the output)
We do deduplication when building the RefSlab. And double-checked with the
output, no duplications there.
Repository:
rCTE Clang Tools Extra
http
hokein updated this revision to Diff 169963.
hokein marked 5 inline comments as done.
hokein added a comment.
Address review comments.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53322
Files:
clangd/index/IndexAction.cpp
clangd/index/IndexAction.h
clangd/index/SymbolCo
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
(please do check there are no duplicates in the output)
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53322
___
cfe-commi
sammccall added a comment.
This looks reasonable. +80% to index size is a shame, but not disastrous, and
we have ways to shave it.
Can you check:
- how much we're increasing the in-memory size (Dex)
- that we're not outputting duplicate refs when preambles overlap between TUs
===
hokein added a comment.
For references, the binary-format index file (for whole llvm project) size:
| Before | WithRef |
| 50MB | 91MB|
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53322
___
cfe-commits mailing list
cfe-com
hokein created this revision.
hokein added a reviewer: sammccall.
Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ioeric,
ilya-biryukov.
Add a flag to SymbolCollector to collect refs fdrom headers.
Note that we collect refs from headers in static index, and we don't do it for
dyn
