[PATCH] D53292: [clangd] Add createIndex in dexp

2018-10-15 Thread Haojian Wu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rCTE344521: [clangd] Add createIndex in dexp (authored by hokein, committed by ). Changed prior to commit: https://reviews.llvm.org/D53292?vs=169712&id=169713#toc Repository: rCTE Clang Tools Extra ht

[PATCH] D53292: [clangd] Add createIndex in dexp

2018-10-15 Thread Haojian Wu via Phabricator via cfe-commits
hokein updated this revision to Diff 169712. hokein marked 2 inline comments as done. hokein added a comment. createIndex => openIndex Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D53292 Files: clangd/index/dex/dexp/Dexp.cpp Index: clangd/index/dex/dexp/Dexp.cpp ==

[PATCH] D53292: [clangd] Add createIndex in dexp

2018-10-15 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clangd/index/dex/dexp/Dexp.cpp:256 +std::unique_ptr createIndex(llvm::StringRef Index) { + return loadIndex(Index, /*URISchemes=*/{}, /*UseDex=*/true

[PATCH] D53292: [clangd] Add createIndex in dexp

2018-10-15 Thread Haojian Wu via Phabricator via cfe-commits
hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ioeric, ilya-biryukov. This would allow easily injecting our internal customization. Also updates the stale "symbol-collection-file" flag. Repository: rCTE Clang