[PATCH] D53266: [clangd] Simplify client capabilities parsing.

2018-10-17 Thread Sam McCall via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL344673: [clangd] Simplify client capabilities parsing. (authored by sammccall, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D53266 Files: cla

[PATCH] D53266: [clangd] Simplify client capabilities parsing.

2018-10-16 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, thanks for the change! Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D53266 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D53266: [clangd] Simplify client capabilities parsing.

2018-10-16 Thread Sam McCall via Phabricator via cfe-commits
sammccall updated this revision to Diff 169839. sammccall added a comment. Rebase to include CodeAction literal support Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D53266 Files: clangd/ClangdLSPServer.cpp clangd/Protocol.cpp clangd/Protocol.h Index: clangd/Protocol.h =

[PATCH] D53266: [clangd] Simplify client capabilities parsing.

2018-10-14 Thread Sam McCall via Phabricator via cfe-commits
sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ioeric, ilya-biryukov. Instead of parsing into structs that mirror LSP, simply parse into a flat struct that contains the info we need. This is an exception to