nruslan added a comment.
@kristina : Thank you very much for taking care of the patchsets!
Repository:
rC Clang
https://reviews.llvm.org/D53102
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
This revision was automatically updated to reflect the committed changes.
Closed by commit rC344739: Add support for -mno-tls-direct-seg-refs to Clang
(authored by kristina, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D53102?vs=169224&id=170082#toc
Repository:
rC Clang
nruslan added a comment.
In https://reviews.llvm.org/D53102#1268364, @kristina wrote:
> By the way, out of curiosity is this for anything specific (alternative libc
> or some user-mode-scheduling implementation)? Not nitpicking, just curious
> since it's an interesting topic in general and it's
kristina added a comment.
By the way, out of curiosity is this for anything specific (alternative libc or
some user-mode-scheduling implementation)? Not nitpicking, just curious since
it's an interesting topic in general and it's frustrating that the architecture
is so limited in terms of regis
nruslan added a comment.
In https://reviews.llvm.org/D53102#1268272, @kristina wrote:
> If the author doesn't mind I can just apply the style fix after patching and
> then rebuild and run all the relevant tests (or would you prefer to do
> that?). Seems easier than a new revision for an indenta
kristina added a comment.
If the author doesn't mind I can just apply the style fix after patching and
then rebuild and run all the relevant tests (or would you prefer to do that?).
Seems easier than a new revision for an indentation change on one line.
https://reviews.llvm.org/D53102
_
craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.
LGTM with that one style comment fixed.
Comment at: lib/Driver/ToolChains/Clang.cpp:1743
+ if (!Args.hasFlag(options::OPT_mtls_direct_seg_refs,
+ options::O
kristina added a comment.
@nruslan This patchset is still pending review so be patient, I landed
https://reviews.llvm.org/D53103 as it was reviewed and accepted by the code
owner, on which this patch depends on. That said it LGTM, it's simple enough as
it just forwards the argument to the backe
nruslan added a comment.
@hans, @craig.topper : If everything is fine, can someone check in the clang
and llvm patches on my behalf? I do not have commit access.
https://reviews.llvm.org/D53102
___
cfe-commits mailing list
cfe-commits@lists.llvm.or
nruslan updated this revision to Diff 169224.
nruslan marked 3 inline comments as done.
nruslan added a comment.
@hans , @craig.topper : Updated the patch with all requested changes
https://reviews.llvm.org/D53102
Files:
include/clang/Driver/Options.td
include/clang/Frontend/CodeGenOptions.
nruslan added inline comments.
Comment at: docs/ClangCommandLineReference.rst:2241
+
+Enable or disable direct TLS access through segment registers
+
hans wrote:
> This file is automatically generated based on the options .td files, so no
> need to update it her
hans added a comment.
Looking good, just a few minor comments.
Comment at: docs/ClangCommandLineReference.rst:2241
+
+Enable or disable direct TLS access through segment registers
+
This file is automatically generated based on the options .td files, so no need
nruslan created this revision.
nruslan added reviewers: hans, craig.topper.
Herald added a subscriber: cfe-commits.
Allows to disable direct TLS segment access (%fs or %gs). GCC supports a
similar flag, it can be useful in some circumstances, e.g. when a thread
context block needs to be updated
13 matches
Mail list logo
