whisperity added a comment.
Let's register the ID...
Superseded by https://reviews.llvm.org/D54429.
https://reviews.llvm.org/D53069
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Szelethus abandoned this revision.
Szelethus added a comment.
Herald added subscribers: gamesh411, baloghadamsoftware.
In https://reviews.llvm.org/D53069#1274554, @george.karpenkov wrote:
> If we want to be serious about this page, it really has to be auto-generated
> (like clang-tidy one), but
Szelethus updated this revision to Diff 171624.
Szelethus added a comment.
Excuse my informality, but `llvm.Conventions` fell flat on its face in my eyes
(details: https://reviews.llvm.org/D53856), so I'm no longer insisting on
including it on this page.
https://reviews.llvm.org/D53069
Files:
Szelethus marked 2 inline comments as done.
Szelethus added inline comments.
Comment at: www/analyzer/available_checks.html:1119
+
+
+
george.karpenkov wrote:
> Top of the checker file has a somewhat reasonable description:
>
> // A checker for detecting leaks r
george.karpenkov requested changes to this revision.
george.karpenkov added a comment.
This revision now requires changes to proceed.
Good to go provided you will add an example.
If we want to be serious about this page, it really has to be auto-generated
(like clang-tidy one), but I understand t
Szelethus marked 14 inline comments as done.
Szelethus added inline comments.
Comment at: www/analyzer/available_checks.html:459
+
george.karpenkov wrote:
> Spurious newline
Actually, in this section of the code, entries are separated with 2 newlines.
But it
Szelethus updated this revision to Diff 170920.
Szelethus edited the summary of this revision.
https://reviews.llvm.org/D53069
Files:
www/analyzer/available_checks.html
Index: www/analyzer/available_checks.html
===
--- www/analyze
george.karpenkov requested changes to this revision.
george.karpenkov added inline comments.
This revision now requires changes to proceed.
Comment at: www/analyzer/available_checks.html:459
+
Spurious newline
Comment at: www/analyzer/avail
NoQ accepted this revision.
NoQ added a comment.
I guess maybe let's skip stuff without examples and leave Objective-C
descriptions waiting on us?
Comment at: www/analyzer/available_checks.html:483
+
+LLVM Checkers
Wow, i never noticed this one. It seems to
george.karpenkov added a comment.
Herald added a subscriber: dkrupp.
@Szelethus Also you have without a doubt noticed that a "Download" section on
the index page could be improved :P
https://reviews.llvm.org/D53069
___
cfe-commits mailing list
cfe-
Szelethus updated this revision to Diff 169342.
Szelethus edited the summary of this revision.
Szelethus added a comment.
- Removed osx.cocoa.Loops, will be placed in implicit_checks.html
I still didn't add more description to objc checkers for the reasons stated
above.
https://reviews.llvm.or
Szelethus added a comment.
Well, the reason why I didn't add tests for these, is that I know so little of
ObjC, I am not even sure when a test case begins and ends. I could go ahead and
google something about the language, but for a site that advertises to find
bugs, maybe someone with more exp
george.karpenkov requested changes to this revision.
george.karpenkov added a comment.
This revision now requires changes to proceed.
Herald added a subscriber: donat.nagy.
Great idea, thanks!
Should be good to go once examples are added, and implicit checks are removed.
Comme
rnkovacs added inline comments.
Comment at: www/analyzer/available_checks.html:376-393
+
+cplusplus.InnerPointer
+(C++)
+Check for inner pointers of C++ containers used after re/deallocation.
+
+
+
Szelethus wrote:
> @rnkovacs Is this a good description of your c
Szelethus added a comment.
Thats a great idea.
About implicit checks, they are so well hidden, I didn't even find them until I
wanted to update the website (although, this is at least in part my fault, but
why would anyone carefully read through a website that hasn't been touched for
years?).
xazax.hun added a comment.
I am not sure what to do about implcit checks. Those are probably should never
be turned on or off by the user, but they should be on or off by default based
on the set of checks the user enabled and the platform she is using. Thus, I am
perfectly ok with the implicit
Szelethus added inline comments.
Comment at: www/analyzer/available_checks.html:376-393
+
+cplusplus.InnerPointer
+(C++)
+Check for inner pointers of C++ containers used after re/deallocation.
+
+
+
@rnkovacs Is this a good description of your checker?
https://
Szelethus updated this revision to Diff 168966.
Szelethus edited the summary of this revision.
Szelethus added a reviewer: rnkovacs.
https://reviews.llvm.org/D53069
Files:
www/analyzer/available_checks.html
Index: www/analyzer/available_checks.html
=
Szelethus created this revision.
Szelethus added reviewers: NoQ, george.karpenkov, MTC, xazax.hun.
Herald added subscribers: cfe-commits, mikhail.ramalho, a.sidorin,
JDevlieghere, rnkovacs, szepet, whisperity.
Title says it all. I never ever used ObjC, so I couldn't really add examples on
many o
19 matches
Mail list logo
