This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rGcbd73574e43e: Reapply: [Driver] Use forward slashes in most
linker arguments (authored by mstorsjo).
Herald added a projec
rnk added a comment.
We discussed adding a new path style that opts into a / preferred separator on
Windows, something like path::Style::windows_forward. All of the absolute path
handling routines would behave the same, but the preferred separator would now
be `/`. We can make the default path
rupprecht resigned from this revision.
rupprecht added a comment.
I'm not familiar with this code or anything windows related, and it looks like
@rnk is, so I'll remove myself and let him approve
Repository:
rL LLVM
https://reviews.llvm.org/D53066
_
mstorsjo reopened this revision.
mstorsjo added a comment.
This revision is now accepted and ready to land.
Nope, still no really working properly with all the tests out there (I had only
run the Driver subdirectory since I'm only testing in a very underpowered VM,
and it had skipped the cuda/hi
This revision was automatically updated to reflect the committed changes.
Closed by commit rL345370: Reapply: [Driver] Use forward slashes in most linker
arguments (authored by mstorsjo, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D53066?vs=170989&id=171253#toc
Repository
rnk accepted this revision.
rnk added a comment.
lgtm
https://reviews.llvm.org/D53066
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mstorsjo updated this revision to Diff 170989.
mstorsjo added a comment.
Changed so that we only rewrite paths if targeting a non-windows OS, or
cygwin/mingw. Since convert_to_slash is a no-op when running on anything else
than windows, this should hit exactly the cases where converting to forwa
mstorsjo added a comment.
In https://reviews.llvm.org/D53066#1274288, @zturner wrote:
> It seems like some combination of checking the target triple, host triple,
> and driver mode and putting the conversions behind those checks could work?
Sounds ok, I can give it a shot. There's probably no
zturner added a subscriber: mstorsjo.
zturner added a comment.
It seems like some combination of checking the target triple, host triple,
and driver mode and putting the conversions behind those checks could work?
For paths like resource dir that are going into debug info it should be
driver mode
It seems like some combination of checking the target triple, host triple,
and driver mode and putting the conversions behind those checks could work?
For paths like resource dir that are going into debug info it should be
driver mode. For paths we pass to another tool it should probably be based
mstorsjo added inline comments.
Comment at: lib/Driver/Driver.cpp:1013-1014
}
+ for (auto *Str : {&Dir, &InstalledDir, &SysRoot, &DyldPrefix, &ResourceDir})
+*Str = llvm::sys::path::convert_to_slash(*Str);
rnk wrote:
> zturner wrote:
> > Is this going t
rnk added inline comments.
Comment at: lib/Driver/Driver.cpp:1013-1014
}
+ for (auto *Str : {&Dir, &InstalledDir, &SysRoot, &DyldPrefix, &ResourceDir})
+*Str = llvm::sys::path::convert_to_slash(*Str);
zturner wrote:
> Is this going to affect the cl driv
zturner added inline comments.
Comment at: lib/Driver/Driver.cpp:1013-1014
}
+ for (auto *Str : {&Dir, &InstalledDir, &SysRoot, &DyldPrefix, &ResourceDir})
+*Str = llvm::sys::path::convert_to_slash(*Str);
Is this going to affect the cl driver as well?
mstorsjo updated this revision to Diff 170755.
mstorsjo retitled this revision from "[RFC] [Driver] Use forward slashes in
most linker arguments" to "[Driver] Use forward slashes in most linker
arguments".
mstorsjo added a comment.
Converting more path instances, enough to fix the tests that fai
14 matches
Mail list logo
