[PATCH] D52843: Update Clang Windows getting started docs

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rC343809: Update Clang Windows getting started docs (authored by rnk, committed by ). Changed prior to commit: https://re

[PATCH] D52843: Update Clang Windows getting started docs

rnk marked an inline comment as done. rnk added a comment. I'm going to go ahead and commit this. Hopefully it's more accurate and useful than what we have, and we can fix any issues in post. https://reviews.llvm.org/D52843 ___ cfe-commits mailing

[PATCH] D52843: Update Clang Windows getting started docs

rnk marked 3 inline comments as done. rnk added inline comments. Comment at: clang/www/get_started.html:179 svn co http://llvm.org/svn/llvm-project/llvm/trunk llvm STL_MSFT wrote: > Can these be HTTPS? (I had to figure out HTTPS incantations for `git

[PATCH] D52843: Update Clang Windows getting started docs

rnk updated this revision to Diff 168205. rnk added a comment. - Use https: where possible over http: - Fix CMake VS generator invocation https://reviews.llvm.org/D52843 Files: clang/www/get_started.html Index: clang/www/get_started.html ==

[PATCH] D52843: Update Clang Windows getting started docs

zturner added inline comments. Comment at: clang/www/get_started.html:246 +"C:\Program Files (x86)\Microsoft Visual + Studio\2017\Professional\VC\Auxiliary\Build\vcvarsall.bat" x64 + zturner wrote: > STL_MSFT wrote: > > This assumes the Pro

[PATCH] D52843: Update Clang Windows getting started docs

zturner added inline comments. Comment at: clang/www/get_started.html:246 +"C:\Program Files (x86)\Microsoft Visual + Studio\2017\Professional\VC\Auxiliary\Build\vcvarsall.bat" x64 + STL_MSFT wrote: > This assumes the Professional SKU; perh

[PATCH] D52843: Update Clang Windows getting started docs

STL_MSFT added inline comments. Comment at: clang/www/get_started.html:160 http://www.cmake.org/cmake/resources/software.html";> http://www.cmake.org/cmake/resources/software.html +Visual Studio 2015 or later This URL redirects to `https://c

[PATCH] D52843: Update Clang Windows getting started docs

steveire added inline comments. Comment at: clang/www/get_started.html:197 +If you are using Visual Studio 2017: + cmake -G "Visual Studio 15 2017 Win64" ..\llvm +This will generate x64 binaries by default, which should perform better. smeenai wrote

[PATCH] D52843: Update Clang Windows getting started docs

smeenai added inline comments. Comment at: clang/www/get_started.html:197 +If you are using Visual Studio 2017: + cmake -G "Visual Studio 15 2017 Win64" ..\llvm +This will generate x64 binaries by default, which should perform better. Does the Win64

[PATCH] D52843: Update Clang Windows getting started docs

rnk created this revision. rnk added reviewers: zturner, STL_MSFT. Herald added a subscriber: jfb. rnk added a subscriber: aaron.ballman. - Update the example VS project generation to use VS2017. - Add docs for generating ninja build files, since they are popular. - Remove reference to "make updat